linux-kernel - Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 26 May 2014 19:49:17 +0200
From:	Willy Tarreau <w@....eu>
To:	Joe Perches <joe@...ches.com>
Cc:	Dominique van den Broeck <domdevlin@...e.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] staging: panel: (coding style) Matching braces

On Mon, May 26, 2014 at 10:28:10AM -0700, Joe Perches wrote:
> On Mon, 2014-05-26 at 16:28 +0200, Willy Tarreau wrote:
> > I believe that most of the kernel code prefers the two-line format resluting
> > in this instead :
> > 
> > 		}
> > 		else if (*esc >= 'A' && *esc <= 'Z') {
> > 			value |= (*esc - 'A' + 10) << shift;
> > 		}
> > 		else if (*esc >= 'a' && *esc <= 'z') {
> > 			value |= (*esc - 'a' + 10) << shift;
> > 		}
> > 		else {
> 
> grep shows what kernel style is most used.
> 
> Your form:
> 	}
> 	else if (...) {
> 
> (This shows 3 lines per instance)
> $ grep-2.5.4 -rP --include=*.[ch] '}\n[ \t]*else if.*{\n' * | wc -l
> 909
> 
> Generally used form:
> 	} else if (...) {
> 
> (mostly shows 2 lines per instance)
> $ grep-2.5.4 -rP --include=*.[ch] '} else if.*{\n' * | wc -l
> 31653
> 
> That's ~50:1 preference for "} else if (...) {"

Ah indeed, I wouldn't have thought that. Thanks for correcting me, Joe!

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/