linux-kernel - Re: [PATCH 1/9] staging: ion: tidy up a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140527094609.GL15585@mwanda>
Date:	Tue, 27 May 2014 12:55:05 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Heesub Shin <heesub.shin@...sung.com>
Cc:	devel@...verdev.osuosl.org,
	Sunghwan Yun <sunghwan.yun@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daeseok Youn <daeseok.youn@...il.com>,
	linux-kernel@...r.kernel.org,
	Arve Hjønnevåg <arve@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Colin Cross <ccross@...roid.com>,
	Rebecca Schultz Zavin <rebecca@...roid.com>,
	Mitchel Humpherys <mitchelh@...eaurora.org>
Subject: Re: [PATCH 1/9] staging: ion: tidy up a bit

On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote:
> Hello Carpenter,
> 
> On 05/26/2014 07:36 PM, Dan Carpenter wrote:
> >On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
> >>@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
> >>
> >>  		info->page = page;
> >>  		info->order = orders[i];
> >>-		INIT_LIST_HEAD(&info->list);
> >>  		return info;
> >>  	}
> >>  	kfree(info);
> >
> >Wait.  How does this code work without that INIT_LIST_HEAD()?  What am
> >I missing here...
> 
> No problem. As the object info is just a node, not a head, it is
> completely useless to initialize it as a list head.
> 

Oh, sorry, you are right.  My bad.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/