linux-kernel - Re: [PATCH 6/9] staging: ion: remove struct page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vnkw61kr5aso.fsf@mitchelh-linux.qualcomm.com>
Date:	Tue, 27 May 2014 11:36:07 -0700
From:	Mitchel Humpherys <mitchelh@...eaurora.org>
To:	Heesub Shin <heesub.shin@...sung.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	Rebecca Schultz Zavin <rebecca@...roid.com>,
	Colin Cross <ccross@...roid.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Daeseok Youn <daeseok.youn@...il.com>,
	Sunghwan Yun <sunghwan.yun@...sung.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] staging: ion: remove struct page_info

On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin <heesub.shin@...sung.com> wrote:
> ION system heap uses a temporary list holding meta data on pages
> allocated to build scatter/gather table. Now that the pages are compound
> pages, we do not need to introduce a new data type redundantly.
>
> Signed-off-by: Heesub Shin <heesub.shin@...sung.com>
> ---
>  drivers/staging/android/ion/ion_system_heap.c | 47 +++++++++------------------
>  1 file changed, 15 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index 73a2e67..f0ae210 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -51,11 +51,6 @@ struct ion_system_heap {
>  	struct ion_page_pool **pools;
>  };
>  
> -struct page_info {
> -	struct page *page;
> -	struct list_head list;
> -};
> -
>  static struct page *alloc_buffer_page(struct ion_system_heap *heap,
>  				      struct ion_buffer *buffer,
>  				      unsigned long order)
> @@ -96,19 +91,14 @@ static void free_buffer_page(struct ion_system_heap *heap,
>  }
>  
>  
> -static struct page_info *alloc_largest_available(struct ion_system_heap *heap,
> -						 struct ion_buffer *buffer,
> -						 unsigned long size,
> -						 unsigned int max_order)
> +static struct page *alloc_largest_available(struct ion_system_heap *heap,
> +					    struct ion_buffer *buffer,
> +					    unsigned long size,
> +					    unsigned int max_order)

Was this whitespace-only change intentional?


-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/