linux-kernel - Re: [PATCH 06/15] staging: rtl8188eu:Remove unused function rtl8188eu_set_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 May 2014 23:43:52 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	navin patidar <navin.patidar@...il.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/15] staging: rtl8188eu:Remove unused function
 rtl8188eu_set_hw_type()

These would have been easier to review if this patch were folded in with
the previous two patches.  What I look for in these patches is, "Will
the compile break if you get it wrong?"

For "[PATCH 04/15] staging: rtl8188eu:Assign RTL8188E to
padapter->chip_type directly", you could get it wrong and the compile
wouldn't break so I have to go into the code and look at it.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/