linux-kernel - Re: [PATCH] mm/zswap : NUMA aware allocation for zswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1405271346190.14064@chino.kir.corp.google.com>
Date:	Tue, 27 May 2014 13:49:04 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Seth Jennings <sjennings@...iantweb.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/zswap : NUMA aware allocation for zswap_dstmem

On Tue, 27 May 2014, Eric Dumazet wrote:

> From: Eric Dumazet <edumazet@...gle.com>
> 
> zswap_dstmem is a percpu block of memory, which should
> be allocated using kmalloc_node(), to get better NUMA
> locality.
> 
> Without it, all the blocks are allocated from a single node.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: David Rientjes <rientjes@...gle.com>

cpu_to_node(cpu) should return the correct node that was parsed from the 
SRAT on x86 at boot during CPU_UP_PREPARE.  If any platform returns 
NUMA_NO_NODE, the worst case scenario is that we get local allocation 
anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/