linux-kernel - Re: [PATCH] mm/zswap : NUMA aware allocation for zswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140529035041.GB18063@cerebellum.variantweb.net>
Date:	Wed, 28 May 2014 22:50:41 -0500
From:	Seth Jennings <sjennings@...iantweb.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] mm/zswap : NUMA aware allocation for zswap_dstmem

On Tue, May 27, 2014 at 09:55:49AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> zswap_dstmem is a percpu block of memory, which should
> be allocated using kmalloc_node(), to get better NUMA
> locality.
> 
> Without it, all the blocks are allocated from a single node.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Seth Jennings <sjennings@...iantweb.net>

> ---
>  mm/zswap.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index aeaef0fb5624..008388fe7b0f 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -347,7 +347,7 @@ static int __zswap_cpu_notifier(unsigned long action, unsigned long cpu)
>  			return NOTIFY_BAD;
>  		}
>  		*per_cpu_ptr(zswap_comp_pcpu_tfms, cpu) = tfm;
> -		dst = kmalloc(PAGE_SIZE * 2, GFP_KERNEL);
> +		dst = kmalloc_node(PAGE_SIZE * 2, GFP_KERNEL, cpu_to_node(cpu));
>  		if (!dst) {
>  			pr_err("can't allocate compressor buffer\n");
>  			crypto_free_comp(tfm);
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/