linux-kernel - Re: [PATCH 1/4] serial: core: Consistent LF handling for poll_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140528200344.GA2750@kroah.com>
Date:	Wed, 28 May 2014 13:03:44 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Daniel Thompson <daniel.thompson@...aro.org>
Cc:	linux-serial@...r.kernel.org, patches@...aro.org,
	linaro-kernel@...ts.linaro.org, linux-kernel@...r.kernel.org,
	John Stultz <john.stultz@...aro.org>,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Colin Cross <ccross@...roid.com>, kernel-team@...roid.com,
	Jason Wessel <jason.wessel@...driver.com>,
	kgdb-bugreport@...ts.sourceforge.net, Jiri Slaby <jslaby@...e.cz>,
	Kumar Gala <galak@...nel.crashing.org>,
	Pantelis Antoniou <panto@...racom.gr>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Joe Schultz <jschultz@...-inc.com>,
	Loic Poulain <loic.poulain@...el.com>,
	Kyle McMartin <kyle@...radead.org>,
	Stephen Warren <swarren@...dia.com>,
	Ingo Molnar <mingo@...e.hu>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Christophe Leroy <christophe.leroy@....fr>
Subject: Re: [PATCH 1/4] serial: core: Consistent LF handling for
 poll_put_char

On Wed, May 14, 2014 at 03:55:32PM +0100, Daniel Thompson wrote:
> The behaviour of the UART poll_put_char infrastructure is inconsistent
> with respect to linefeed conversions. This in turn leads to difficulty
> using kdb on serial ports that are not also consoles
> (e.g. console=ttyAMA0,115200 kgdboc=ttyAMA1,115200).
> 
> The following drivers automatically convert '\n' to '\r\n' inside their
> own poll functions but the remaining seventeen do not:
> 
>     serial8250, cpm, pch_uart, serial_pxa, serial_txx9,
> 
> This can be made fully consistent but performing the conversion in
> uart_poll_put_char(). A similar conversion is already made inside
> uart_console_write() but it is optional for drivers to use this
> function. Fortunately we can be confident the translation is safe
> because the (very common) 8250 already does this translation.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Kumar Gala <galak@...nel.crashing.org>
> Cc: Pantelis Antoniou <panto@...racom.gr>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Joe Schultz <jschultz@...-inc.com>
> Cc: Loic Poulain <loic.poulain@...el.com>
> Cc: Kyle McMartin <kyle@...radead.org>
> Cc: Stephen Warren <swarren@...dia.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Grant Likely <grant.likely@...aro.org>
> Cc: Rob Herring <rob.herring@...xeda.com>
> Cc: Jingoo Han <jg1.han@...sung.com>
> Cc: Christophe Leroy <christophe.leroy@....fr>
> ---
>  drivers/tty/serial/8250/8250_core.c         | 5 -----

This patch doesn't apply to my tty-next branch anymore, as it seems that
part of it is already there, right?

Can you respin this whole series and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/