linux-kernel - Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53864E91.4060207@linux.intel.com>
Date:	Wed, 28 May 2014 14:01:05 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	Andy Lutomirski <luto@...capital.net>,
	Philipp Kern <pkern@...gle.com>
CC:	linux-kernel@...r.kernel.org, "H. J. Lu" <hjl.tools@...il.com>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH] x32: Mask away the x32 syscall bit in the ptrace codepath

On 05/28/2014 01:47 PM, Andy Lutomirski wrote:
> On 05/28/2014 05:19 AM, Philipp Kern wrote:
>> audit_filter_syscall uses the syscall number to reference into a
>> bitmask (e->rule.mask[word]). Not removing the x32 bit before passing
>> the number to this architecture independent codepath will fail to
>> lookup the proper audit bit. Furthermore it will cause an invalid memory
>> access in the kernel if the out of bound location is not mapped:
>>
>>   BUG: unable to handle kernel paging request at ffff8800e5446630
>>   IP: [<ffffffff810fcdd0>] audit_filter_syscall+0x90/0xf0
>>
>> Together with the entrypoint in entry_64.S this change causes x32
>> programs to pass in both AUDIT_ARCH_X86_64 and AUDIT_ARCH_I386 depending
>> on the syscall path.
>>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: H. J. Lu <hjl.tools@...il.com>
>> Cc: Eric Paris <eparis@...hat.com>
>> Signed-off-by: Philipp Kern <pkern@...gle.com>
>> ---
>>  arch/x86/kernel/ptrace.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
>> index 678c0ad..166a3c7 100644
>> --- a/arch/x86/kernel/ptrace.c
>> +++ b/arch/x86/kernel/ptrace.c
>> @@ -1489,7 +1489,7 @@ long syscall_trace_enter(struct pt_regs *regs)
>>  
>>  	if (IS_IA32)
>>  		audit_syscall_entry(AUDIT_ARCH_I386,
>> -				    regs->orig_ax,
>> +				    regs->orig_ax & __SYSCALL_MASK,
> 
> This is weird.  Three questions:
> 
> 1. How can this happen?  I thought that x32 syscalls always came in
> through the syscall path, which doesn't set is_compat_task.  (Can
> someone rename is_compat_task to in_compat_syscall?  Pretty please?)

The SYSCALL path doesn't set TS_COMPAT, but is_compat_task() looks both
as TS_COMPAT and bit 30 of orig_ax.

I think what is really needed here is IS_IA32 should use is_ia32_task()
instead, and *that* is the context we can mask off the x32 bit in at
all.  However, does audit not need that information?

(And why the frakk does audit receive the first four syscall arguments?
 Audit seems like the worst turd ever...)

> 2. Now audit can't tell whether a syscall is x32 or i386.  And audit is
> inconsistent with seccomp.  This seems wrong.

This is completely and totally bogus, indeed.

> 3. The OOPS you're fixing doesn't seem like it's fixed.  What if some
> other random high bits are set?

There is a range check in entry_*.S for the system call.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/