linux-kernel - Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFcVEC+X1NVZHubRWa4qUfEPiugBrp0ewZkjhrcdK1zrht+FXw@mail.gmail.com>
Date:	Thu, 29 May 2014 15:08:41 +0530
From:	Harini Katakam <harinikatakamlinux@...il.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"wim@...ana.be" <wim@...ana.be>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"rob@...dley.net" <rob@...dley.net>,
	"michals@...inx.com" <michals@...inx.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

Hi Mark,

On Thu, May 29, 2014 at 2:51 PM, Mark Rutland <mark.rutland@....com> wrote:
> On Tue, May 27, 2014 at 11:18:14AM +0100, Harini Katakam wrote:
>> Add Cadence WDT driver. This is used by Xilinx Zynq.
>>
>> Signed-off-by: Harini Katakam <harinik@...inx.com>
>> ---
>>
>> Sorry for the delay in sending v2.
>> v2 changes:
>> - Update IO helpers.
>> - Use dev_dbg instead of dev_info where possible.
>> - Use watchdog_init_timeout
>> - Spinlock for restart register where missing.
>> - Change order of probe to move reboot notifier register to the end
>> - Remove unecessary comments
>> - Do clk_prepare_enabel and clk_disable_unprepare in resume/suspend
>>   respectively.
>> - There is an input from dts to decide whether internal reset should be
>>   enabled or not. When this is enabled, reset happens wutomatically when
>>   counter reaches zero. In case this is not enabled, a message is disaplayed
>>   to indicate that the watchdog has timed out. Elaborated this message
>>   to describe the above.
>
> When is that useful?
>

Automatic reset enable is an option. When it's not selected, this is a generic
way of giving some indication. If some other action is preferred
instead of reset,
then that can be added here.

Regards,
Harini
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/