linux-kernel - Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53870129.5010505@monstr.eu>
Date:	Thu, 29 May 2014 11:43:05 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Mark Rutland <mark.rutland@....com>,
	Harini Katakam <harinik@...inx.com>
CC:	"wim@...ana.be" <wim@...ana.be>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"rob@...dley.net" <rob@...dley.net>,
	"michals@...inx.com" <michals@...inx.com>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] watchdog: Add Cadence WDT driver

Hi Mark,

>> +static struct of_device_id cdns_wdt_of_match[] = {
>> +       { .compatible = "xlnx,zynq-wdt-r1p2", },
>> +       { .compatible = "cdns,wdt-r1p2", },
> 
> If these can currently be handled identically, why not just have
> "cdns,wdt-r1p2" in the driver and in your dts have:
> 
> compatible = "xlnx,zynq-wdt-r1p2", "cdns,wdt-r1p2";
> 
> If we need to distinguish the two for some reason later we can always
> add the "xlnx,zynq-wdt-r1p2" string to the driver.

I would prefer to have 2 compatible strings just because
of that we don't know what is different compare to origin cadence
version. We have done the same for spi-cadence.c that's why
it shouldn't be any problem to keep it as is.
Having zynq compatible property here and using it give us option
that if another SoC vendor come with new configuration or clean
cadence one we can simple handle it without changing compatible
property for us.

thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)