linux-kernel - Re: [patch]blk-mq: blk_mq_tag_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 May 2014 08:09:51 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Shaohua Li <shli@...nel.org>, Christoph Hellwig <hch@...radead.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request

On 2014-05-09 22:00, Shaohua Li wrote:
> On Fri, May 09, 2014 at 08:00:18AM -0700, Christoph Hellwig wrote:
>> On Fri, May 09, 2014 at 08:07:33PM +0800, Shaohua Li wrote:
>>>
>>> flush request is special, which borrows tag from other request. Need a special
>>> handling to get it from tag.
>>
>> Thanks, we probably need this one.  But I think you can simply test
>> REQ_FLUSH_SEQ the passed in request instead of the flush_rq_tag_valid
>> flag/
>
> fair enough. updated one.
>
>
> Subject: blk-mq: blk_mq_tag_to_rq should handle flush request
>
> flush request is special, which borrows tag from other request. Need a special
> handling to get it from tag.

I have applied this one, but it irks me a little bit since we have to 
touch q->flush_rq->stuff from a potential hot path. I haven't thought 
much about this yet, but it would be a lot better if we could fold in 
the flush tag somehow.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/