linux-kernel - Re: [PATCH 2/2] gpio: gpiolib: set gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140530154859.GK17197@linux-mips.org>
Date:	Fri, 30 May 2014 17:48:59 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	abdoulaye berthe <berthe.ab@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>, m@...s.ch,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux MIPS Mailing List <linux-mips@...ux-mips.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	patches@...nsource.wolfsonmicro.com,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	linux-samsungsoc@...r.kernel.org, spear-devel@...t.st.com,
	platform-driver-x86@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	driverdevel <devel@...verdev.osuosl.org>
Subject: Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:

> > +               if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > +                       panic("gpio: removing gpiochip with gpios still requested\n");
> 
> panic?
> 
> Is this likely to happen?

And while we're at it - panic() is going to add a \n itself so don't pass a
string ending in \n to panic().

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/