linux-kernel - Re: [PATCH v5 02/13] mmc: mmci: convert register bits to use BIT() macro.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140531123502.GB20736@n2100.arm.linux.org.uk>
Date:	Sat, 31 May 2014 13:35:02 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	srinivas.kandagatla@...aro.org
Cc:	Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org,
	Chris Ball <chris@...ntf.net>, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linus.walleij@...aro.org
Subject: Re: [PATCH v5 02/13] mmc: mmci: convert register bits to use BIT()
	macro.

On Fri, May 30, 2014 at 06:13:00PM +0100, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> This patch converts the register bits in the header file to use BIT(()
> macro, which looks much neater.
> 
> No functional changes done.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

This makes me wonder when we're going to get these definitions in the kernel
source, and have people running around making the conversion:

#define ZERO 0
#define ONE 1
#define TWO 2
#define THREE 3
#define FOUR 4
...

because allegedly it makes it more "readable".  I don't see much benefit
to this patch.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/