linux-kernel - Re: [PATCH] Thunderbolt: Add support for Thunderbolt 2 host controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1401660332.7663.26.camel@x230>
Date:	Sun, 1 Jun 2014 22:05:32 +0000
From:	Matthew Garrett <matthew.garrett@...ula.com>
To:	"andreas.noever@...il.com" <andreas.noever@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"greg@...ah.com" <greg@...ah.com>,
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>
Subject: Re: [PATCH] Thunderbolt: Add support for Thunderbolt 2 host
 controllers

On Sun, 2014-06-01 at 22:42 +0200, Andreas Noever wrote:

> Just to check: Did they split up the device ids? Is 0x156d for the
> bridges and 0x156c for the NHI?

Yes. Some kind of progress. I did notice that the Apple driver binds to
all devices with the system peripheral class, vendor 8086 and device
15xx - I don't think we can represent that in Linux at the moment.

> I have had a look at what os x does. They split between:
> 1513, 151a, 1549 and 1547, 1548, 1567, 1569, 156b, 156d (the latter
> group gets bit 3 set)
> 
> It looks like the first 3 are legacy devices, so maybe reverse the check?

Seems fair. I probably won't have time to resend for a couple of days -
if it's easier, please do just rework this yourself.

-- 
Matthew Garrett <matthew.garrett@...ula.com>