linux-kernel - Re: [PATCH 5/6] staging: dgap: unwind on error in dgap_tty_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140602075731.GS17724@mwanda>
Date:	Mon, 2 Jun 2014 10:57:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	lidza.louina@...il.com, gregkh@...uxfoundation.org,
	markh@...pro.net, driverdev-devel@...uxdriverproject.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] staging: dgap: unwind on error in
 dgap_tty_register_ports()

On Mon, Jun 02, 2014 at 02:08:24PM +0900, Daeseok Youn wrote:
> @@ -4177,12 +4183,46 @@ static int dgap_tty_register_ports(struct board_t *brd)
>  					brd->print_driver,
>  					brd->firstminor + i, NULL);

Btw, the "brd->firstminor + i" should just be "i".

TODO-list: 2014-06-02: dgap: get rid of brd->first minor because it is 0

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/