linux-kernel - Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140602100201.GX5099@sirena.org.uk>
Date:	Mon, 2 Jun 2014 11:02:01 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arvind Chauhan <arvind.chauhan@....com>,
	Eduardo Valentin <edubezval@...il.com>,
	Pavel Machek <pavel@....cz>,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 1/2] regulators: Add definition of
 regulator_set_voltage_time() for !CONFIG_REGULATOR

On Mon, Jun 02, 2014 at 03:24:05PM +0530, Viresh Kumar wrote:
> On 2 June 2014 15:21, Mark Brown <broonie@...nel.org> wrote:

> > When you say they check for a valid regulator how are they doing that?
> > The stub will come into play if there isn't a dependency on REGULATOR.

> I meant they fail and quit if regulator_get() failed and so the first parameter
> to regulator_set_voltage() is guaranteed to be valid.

No, think about what you're changing here.  You're changing the stub -
the stub has a regulator_get() which always succeeeds.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)