linux-kernel - Re: [PATCH RFC] block: Eliminate first argument of submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Jun 2014 10:04:37 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Bart Van Assche <bvanassche@....org>
CC:	Kent Overstreet <kmo@...erainc.com>, Shaohua Li <shli@...nel.org>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] block: Eliminate first argument of submit_bio()

On 2014-06-02 03:44, Bart Van Assche wrote:
> The submit_bio() API is confusing. Merge functions like
> raid5_mergeable_bvec() can only work correctly if bi_rw is set
> before bio_add_page() has been called. submit_bio() modifies
> bi_rw after bio_add_page() has been called. Hence remove the
> first argument of submit_bio() and let the caller set bi_rw.
> Note: some but not all submit_bio() callers have been fixed
> such that bi_rw is set before bio_add_page() is called.
>
> See also http://thread.gmane.org/gmane.comp.file-systems.ocfs2.devel/7988
> for a prior discussion of this topic.
>
> Compile tested only, hence the "RFC".

It's a good cleanup, makes the API harder to misuse. The fact that rw 
needs to be set before add_page() was a later addition, and we've 
suffered from that.

Will need some testing, but after that should be good for 3.17.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/