lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 02 Jun 2014 10:14:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Federico Di Pierro <nierro92@...il.com>
Cc:	jic23@...nel.org, gregkh@...uxfoundation.org, jg1.han@...sung.com,
	sachin.kamat@...aro.org, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix some coding style problem in
 drivers/staging/iio/frequency/ad9832.c

On Mon, 2014-06-02 at 19:05 +0200, Federico Di Pierro wrote:
> Hi!

Hello Federico.

> This is my latest task of the eudyptula challenge.

Your patch subject should be something like:

[PATCH] staging: iio: kernel style neatening

> Just a very small patch! It fixes 3 little coding style problems.
> I'm using linux-next.

linux/drivers/staging/iio/frequency/ad9832.c
[]
@@ -73,7 +73,7 @@ static int ad9832_write_phase(struct ad9
 }
 
 static ssize_t ad9832_write(struct device *dev,
-               struct device_attribute *attr,
+                           struct device_attribute *attr,
                const char *buf,
                size_t len)


checkpatch is a brainless little tool.

Please make sure your own brain is engaged when
acting on or verifying any warnings it emits.

Please expand the indented line range to include
all the arguments of the function.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ