linux-kernel - Re: [PATCH v3 1/6] i2c: s3c2410: Handle i2c sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140602171428.GK2654@katana>
Date:	Mon, 2 Jun 2014 19:14:28 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Pankaj Dubey <pankaj.dubey@...sung.com>
Cc:	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kgene.kim@...sung.com,
	t.figa@...sung.com, arnd@...db.de,
	Rob Herring <robh+dt@...nel.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-i2c@...r.kernel.org
Subject: Re: [PATCH v3 1/6] i2c: s3c2410: Handle i2c sys_cfg register in i2c
 driver

On Sat, May 10, 2014 at 04:20:14PM +0900, Pankaj Dubey wrote:
> Let's handle i2c interrupt re-configuration in i2c driver. This will
> help us in removing some soc specific checks from machine files.
> Since only Exynos5250, and Exynos5420 need to do this, added syscon
> based phandle to i2c device nodes of respective SoC DT files.
> Also handle saving and restoring of SYS_I2C_CFG register during
> suspend and resume of i2c driver. This will help in removing soc
> specific check from mach-exynos/pm.c.
> 
> CC: Rob Herring <robh+dt@...nel.org>
> CC: Randy Dunlap <rdunlap@...radead.org>
> CC: Wolfram Sang <wsa@...-dreams.de>
> CC: Russell King <linux@....linux.org.uk>
> CC: devicetree@...r.kernel.org
> CC: linux-doc@...r.kernel.org
> CC: linux-i2c@...r.kernel.org
> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>

Shall this go via i2c-tree? Looks to me like it should go with the rest
of the series? Patch is mostly okay (only reviewed the code, not the
bindings), one nit:

> +	regmap_update_bits(i2c->sysreg, EXYNOS5_SYS_I2C_CFG, BIT(id), val);

Hardcode the '0' and drop using 'val'?


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)