linux-kernel - Re: Unionmount and overlayfs testsuite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUV5P=fVwe_MJJHixwBOBoj7HoKSFuySLdS6AU5L++S=4g@mail.gmail.com>
Date:	Tue, 3 Jun 2014 10:08:46 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	"J. R. Okajima" <hooanon05g@...il.com>,
	Miklos Szeredi <miklos@...redi.hu>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>, apw@...onical.com,
	Felix Fietkau <nbd@...nwrt.org>, neilb@...e.de,
	jordipujolp@...il.com, ezk@....cs.sunysb.edu, mszeredi@...e.cz
Subject: Re: Unionmount and overlayfs testsuite

On Fri, May 30, 2014 at 10:49 AM, David Howells <dhowells@...hat.com> wrote:
> J. R. Okajima <hooanon05g@...il.com> wrote:
>
>> I've found some interesting cases.
>>
>> - impermissible.test,
>>       open_file_as_bin -t -w $file -E EACCES
>>   When $termslash is "/", a '/' is appended to the expanded $file, such
>>   as "/path/fileA/". If fileA is a regular file, that path is obviously
>>   wrong. Does UnionMount expect EACCES in this case too?
>>   Should it be ENOTDIR?
>>   It might be better to change
>>       errcode=EACCES
>>       test ! "$termslash" = "" && errcode=ENOTDIR
>>       open_file_as_bin -t -w $file -E $errcode
>
> I'd never got to the end of the impermissible test because the utimes test
> fails on both unionmount and overlayfs.  I'll have to address the termslash
> alterations at some point.
>

[ Re-Tested with 3.15.0-rc8-1-iniza-lockdep ]

Running the impermissible test on OverlayFS with TERMSLASH=1 is
successful here (TERMSLASH=0 still fails):

# LC_ALL=C TEST_OVERLAYFS=1 TERMSLASH=1 ./run.sh

[ NOTE-1: I still see the reported call-trace which you Dave see as a
problem in OverlayFS. ]
[ NOTE-2: The call-trace I have seen once (TERMSLASH=0). ]

[ ^^ Miklos any idea? ]

Diverse logs, kernel-config and dmesg files attached.

Hope this feedback helps you.

- Sedat -

View attachment "dmesg_TERMSLASH-0_3.15.0-rc8-1-iniza-lockdep.txt" of type "text/plain" (59749 bytes)

Download attachment "config-3.15.0-rc8-1-iniza-lockdep" of type "application/octet-stream" (119079 bytes)

View attachment "dmesg_TERMSLASH-1_3.15.0-rc8-1-iniza-lockdep.txt" of type "text/plain" (59990 bytes)

View attachment "run-sh-log_TERMSLASH-0_3.15.0-rc8-1-iniza-lockdep.txt" of type "text/plain" (37864 bytes)

View attachment "run-sh-log_TERMSLASH-1_3.15.0-rc8-1-iniza-lockdep.txt" of type "text/plain" (43507 bytes)