linux-kernel - Re: Unionmount and overlayfs testsuite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUVRoCxk3Grte6CSqs6h=_BJAR-Z75v0kCDdnzc_Pf2baA@mail.gmail.com>
Date:	Tue, 3 Jun 2014 12:15:10 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	David Howells <dhowells@...hat.com>,
	"J. R. Okajima" <hooanon05g@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Robo Bot <apw@...onical.com>, Felix Fietkau <nbd@...nwrt.org>,
	Neil Brown <neilb@...e.de>,
	Jordi Pujol <jordipujolp@...il.com>, ezk@....cs.sunysb.edu,
	"mszeredi@...e.cz" <mszeredi@...e.cz>
Subject: Re: Unionmount and overlayfs testsuite

On Tue, Jun 3, 2014 at 11:42 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
> On Tue, Jun 3, 2014 at 11:26 AM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>> On Tue, Jun 3, 2014 at 11:18 AM, Sedat Dilek <sedat.dilek@...il.com> wrote:
>>> [...]
>>>>> [ NOTE-2: The call-trace I have seen once (TERMSLASH=0). ]
>>>>
>>>> Do you know for which operation?
>
> This still looks like the same annotation problem in
> generic_file_splice_write() I already sent a patch for.
>
> Fix now pushed to overlayfs.v22/overlayfs.current.
>

I have applied "vfs: fix wrong lockdep annotation in
generic_file_splice_write()" to my latest Linux-kernel and
truncate.test seems to be fine, now.
Feel free to add my Tested-by/Reported-by when you spinout a new
version of overlayfs in your Git tree.

For the sake of completeness my simple hack to identify the fs-op...

--- a/truncate.test
+++ b/truncate.test
@@ -33,6 +33,8 @@ for ((loop=0; loop<29; loop++)) {
        fi

        fs_op truncate $file $loop
+       echo "1st FS-OP: XXX"
+       dmesg | tail

        assert_is_upper $file
        post=`stat --printf %s $file`
@@ -48,5 +50,7 @@ for ((loop=0; loop<29; loop++)) {
        fi
     else
        fs_op truncate $file $loop -E ENOTDIR
+       echo "2nd FS-OP: XXX"
+       dmesg | tail
     fi
 }

All tests now run fine!

    # LC_ALL=C TEST_OVERLAYFS=1 TERMSLASH=1 ./run.sh

Thanks for all involved people.

- Sedat -

View attachment "run-sh-log_truncate-test_LOCKDEP-FIXED.txt" of type "text/plain" (50467 bytes)

View attachment "run-sh-log_TEST_OVERLAYFS-1_TERMSLASH-1_3.15.0-rc8-2-iniza-lockdep_LOCKDEP-FIXED.txt" of type "text/plain" (43507 bytes)