[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.10.1406030948310.13291@gentwo.org>
Date: Tue, 3 Jun 2014 09:48:51 -0500 (CDT)
From: Christoph Lameter <cl@...two.org>
To: Vladimir Davydov <vdavydov@...allels.com>
cc: akpm@...ux-foundation.org, hannes@...xchg.org, mhocko@...e.cz,
linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH -mm 5/8] slab: remove kmem_cache_shrink retval
On Tue, 3 Jun 2014, Vladimir Davydov wrote:
> Still, I really want to evict all empty slabs from cache on memcg
> offline for sure. Handling failures there means introducing a worker
> that will retry shrinking, but that seems to me as an unnecessary
> complication, because there's nothing that can prevent us from shrinking
> empty slabs from the cache, even if we merge slab defragmentation, isn't
> it?
>
> May be, it's worth introducing a special function, say kmem_cache_zap(),
> that will only evict empty slabs from the cache, plus disable empty
> slabs caching? This function would be called only from memcg offline for
> dead memcg caches.
I am fine with the lower impact version that you came up with later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists