lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Jun 2014 20:21:42 +0200 From: Ingo Molnar <mingo@...nel.org> To: Oleg Nesterov <oleg@...hat.com> Cc: Ingo Molnar <mingo@...e.hu>, Denys Vlasenko <dvlasenk@...hat.com>, Jim Keniston <jkenisto@...ibm.com>, Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>, Srikar Dronamraju <srikar@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] uprobes/x86: Rename arch_uprobe->def into ->dflt, minor comment updates * Oleg Nesterov <oleg@...hat.com> wrote: > Purely cosmetic, no changes in .o, > > 1. As Jim pointed out arch_uprobe->def looks ambiguous, rename it to > ->dflt. > > 2. Add the comment into default_post_xol_op() to explain "regs->sp +=". > > 3. Remove the stale part of the comment in arch_uprobe_analyze_insn(). > > Suggested-by: Jim Keniston <jkenisto@...ibm.com> > Signed-off-by: Oleg Nesterov <oleg@...hat.com> > --- > arch/x86/include/asm/uprobes.h | 2 +- > arch/x86/kernel/uprobes.c | 37 ++++++++++++++++++------------------- > 2 files changed, 19 insertions(+), 20 deletions(-) > > diff --git a/arch/x86/include/asm/uprobes.h b/arch/x86/include/asm/uprobes.h > index 7be3c07..b3d9442 100644 > --- a/arch/x86/include/asm/uprobes.h > +++ b/arch/x86/include/asm/uprobes.h > @@ -52,7 +52,7 @@ struct arch_uprobe { > struct { > u8 fixups; > u8 ilen; > - } def; > + } dflt; Pls lts nt use slly abbrvtns, ok? How about arch_uprobe->default? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists