linux-kernel - Re: [PATCH 07/32] perf kbuild: remove useless #ifdef directives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538E7C20.2060407@gmail.com>
Date:	Tue, 03 Jun 2014 19:53:36 -0600
From:	David Ahern <dsahern@...il.com>
To:	Alexis Berlemont <alexis.berlemont@...il.com>,
	linux-kernel@...r.kernel.org
CC:	jolsa@...hat.com, mingo@...nel.org, sam@...nborg.org,
	mmarek@...e.cz
Subject: Re: [PATCH 07/32] perf kbuild: remove useless #ifdef directives

missing commit message as to why the ifdef directives useless.

if I build perf after applying this patch and I don't have devel code 
for tui and gui will it still build?

David

On 6/3/14, 4:06 PM, Alexis Berlemont wrote:
> ---
>   tools/perf/ui/setup.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/tools/perf/ui/setup.c b/tools/perf/ui/setup.c
> index 66ecd08..cb69740 100644
> --- a/tools/perf/ui/setup.c
> +++ b/tools/perf/ui/setup.c
> @@ -71,20 +71,16 @@ void setup_browser(bool fallback_to_pager)
>
>   	switch (use_browser) {
>   	case 2:
> -#if defined(CONFIG_GUI) || !defined(CONFIG_KBUILD)
>   		if (setup_gtk_browser() == 0)
>   			break;
>   		printf("GTK browser requested but could not find %s\n",
>   		       PERF_GTK_DSO);
>   		sleep(1);
> -#endif
>   		/* fall through */
> -#if defined(CONFIG_TUI) || !defined(CONFIG_KBUILD)
>   	case 1:
>   		use_browser = 1;
>   		if (ui__init() == 0)
>   			break;
> -#endif
>   		/* fall through */
>   	default:
>   		use_browser = 0;
> @@ -100,16 +96,12 @@ void exit_browser(bool wait_for_ok __maybe_unused)
>   {
>   	switch (use_browser) {
>   	case 2:
> -#if defined(CONFIG_GUI) || !defined(CONFIG_KBUILD)
>   		exit_gtk_browser(wait_for_ok);
>   		break;
> -#endif
>
> -#if defined(CONFIG_TUI) || !defined(CONFIG_KBUILD)
>   	case 1:
>   		ui__exit(wait_for_ok);
>   		break;
> -#endif
>
>   	default:
>   		break;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/