linux-kernel - Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Jun 2014 19:59:50 -0600
From:	David Ahern <dsahern@...il.com>
To:	Alexis Berlemont <alexis.berlemont@...il.com>,
	linux-kernel@...r.kernel.org
CC:	jolsa@...hat.com, mingo@...nel.org, sam@...nborg.org,
	mmarek@...e.cz, Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)

On 6/3/14, 4:05 PM, Alexis Berlemont wrote:
> Alexis Berlemont (29):
>    kbuild: add support of custom paths for "auto.conf*" files
>    perf kbuild: fix recursive invocation of config/features-checks
>    perf kbuild: store in config-detected missing variables (libdir, ...)
>    perf kbuild: remove useless #ifdef directives
>    perf kbuild: fix a link issue if BUILTIN_TRACE is disabled
>    perf kbuild: add missing files and missing flags in Kbuild files
>    perf kbuild: update kbuild files according to last changes
>    perf kbuild: remove legacy slang-related build variables
>    perf kbuild: remove legacy libaudit-related build variables
>    perf kbuild: remove legacy libgtk2-related build variables
>    perf kbuild: remove legacy libperl-related build variables
>    perf kbuild: remove legacy timerfd-related build variable
>    perf kbuild: remove legacy demangle-related build variables
>    perf kbuild: remove legacy on_exit-related build variable
>    perf kbuild: remove legacy backtrace-related build variable
>    perf kbuild: remove legacy numa-related build variable
>    perf kbuild: remove legacy bionic-related build variable
>    perf kbuild: remove legacy libelf-related build variables (1st part)
>    perf kbuild: remove legacy libelf-related build variables (2nd part)
>    perf kbuild: remove legacy libdwarf-related build variables
>    perf kbuild: remove legacy libpython-related build variable
>    perf kbuild: add generated Kconfig build-test cases
>    perf kbuild: fix installation of traceevent plugins
>    perf kbuild: fix tarpkg target in tests/make
>    perf kbuild: update Kbuild files with new and removed sources
>    perf kbuild: update build test configurations
>    perf kbuild: relocate the configs generating script
>    perf kbuild: minor changes
>    perf kbuild: remove Makefile.perf


In general you are missing commit messages that explain why the patch is 
needed -- what does it do, what is changed. The code should evolve from 
where it is to where you want it to be in small focused patches that do 
not break compiles or features (important for git-bisect).

For patches that you are leveraging from Jiri odds are they need to be 
updated for what has happened over the past year since Jiri's last 
effort on this. I suggest doing the updates in line with Jiri's patch 
and add a comment of what was added to Jiri's patch.

Also add Namhyung Kim <namhyung@...nel.org> to your CC list.

Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/