linux-kernel - Re: [PATCH 03/32] perf tools: Kbuild source related fixies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2014 08:49:51 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	David Ahern <dsahern@...il.com>
Cc:	Alexis Berlemont <alexis.berlemont@...il.com>,
	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...hat.com>,
	mingo@...nel.org, sam@...nborg.org, mmarek@...e.cz,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Borislav Petkov <bp@...en8.de>, linux-kbuild@...r.kernel.org,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 03/32] perf tools: Kbuild source related fixies

On Tue, 2014-06-03 at 19:49 -0600, David Ahern wrote:
> On 6/3/14, 4:05 PM, Alexis Berlemont wrote:
> > From: Jiri Olsa <jolsa@...hat.com>
> > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> > index c852c7a..b255c20 100644
> > --- a/tools/perf/builtin-lock.c
> > +++ b/tools/perf/builtin-lock.c
> > @@ -992,9 +992,11 @@ int cmd_lock(int argc, const char **argv, const char *prefix __maybe_unused)
> >   				usage_with_options(report_usage, report_options);
> >   		}
> >   		rc = __cmd_report(false);
> > +#ifdef CONFIG_BULTIN_SCRIPT
> >   	} else if (!strcmp(argv[0], "script")) {
> >   		/* Aliased to 'perf script' */
> > -		return cmd_script(argc, argv, prefix);
> > +		rc = cmd_script(argc, argv, prefix);
> > +#endif
> >   	} else if (!strcmp(argv[0], "info")) {
> >   		if (argc) {
> >   			argc = parse_options(argc, argv,
> 
> Since you are not adding builtin-cmds.h as an included file this change 
> takes away functionality.

And I guess that, because of the typo in CONFIG_BULTIN_SCRIPT, that
would also be true if builtin-cmds.h were actually included.

>  Each patch should ensure that existing options 
> continue to work after the change.
> 
> ditto for all of the other changes to other files.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/