linux-kernel - Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538F6DEB.2000601@redhat.com>
Date:	Wed, 04 Jun 2014 21:05:15 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Venkatesh Srinivas <venkateshs@...gle.com>
CC:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	hch@....de, JBottomley@...allels.com, stable@...r.kernel.org,
	Venkatesh Srinivas <vsrinivas@...101.org>
Subject: Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted
 requests

Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto:
> Do you really want to poll the request VQs for completions if the TMF
> was rejected?

I wasn't sure, but bugs in this path are hard enough that I preferred 
the safer patch.

> TMF ABORT may return FUNCTION REJECTED if the command to abort
> completed before the device saw the TMF ABORT message, for example. In
> such cases, this would
> unnecessarily lengthen the EH path.

The cost of virtscsi_poll_requests should be nothing compared to the 
delay between the timeout and the invocation of the delayed_work, no?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/