linux-kernel - Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHdzE--6krnQ2H9yyfNzX5Y4RoZs-XfKdmFzPufxpMp5hx33pQ@mail.gmail.com>
Date:	Wed, 4 Jun 2014 20:10:45 -0700
From:	Venkatesh Srinivas <venkateshs@...gle.com>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	hch@....de, JBottomley@...allels.com, stable@...r.kernel.org,
	Venkatesh Srinivas <vsrinivas@...101.org>
Subject: Re: [PATCH v3 5/6] virtio-scsi: fix various bad behavior on aborted requests

On 6/4/14, Paolo Bonzini <pbonzini@...hat.com> wrote:
> Il 04/06/2014 19:29, Venkatesh Srinivas ha scritto:
>> Do you really want to poll the request VQs for completions if the TMF
>> was rejected?
>
> I wasn't sure, but bugs in this path are hard enough that I preferred
> the safer patch.

Ok. As long as it was deliberate. I'd slightly prefer only doing so in
the success case, but simplicity is a compelling argument :)

Reviewed-by: Venkatesh Srinivas <venkateshs@...gle.com>

-- vs;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/