| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1401917290-2689-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Wed, 4 Jun 2014 23:28:10 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Randy Dunlap <rdunlap@...radead.org>, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> Cc: Stefan Weil <sw@...lnetz.de>, Jiri Kosina <jkosina@...e.cz>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] Documentation: laptops: hpfall.c: Cleaning up missing null-terminate after strncpy call Added a guaranteed null-terminate after call to strncpy. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> --- Documentation/laptops/hpfall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/laptops/hpfall.c b/Documentation/laptops/hpfall.c index b85dbba..6708432 100644 --- a/Documentation/laptops/hpfall.c +++ b/Documentation/laptops/hpfall.c @@ -28,6 +28,7 @@ int set_unload_heads_path(char *device) if (strlen(device) <= 5 || strncmp(device, "/dev/", 5) != 0) return -EINVAL; strncpy(devname, device + 5, sizeof(devname)); + devname[sizeof(devname) - 1] = '\0'; snprintf(unload_heads_path, sizeof(unload_heads_path) - 1, "/sys/block/%s/device/unload_heads", devname); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists