[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1401994068-820-1-git-send-email-vidyas@nvidia.com>
Date: Fri, 6 Jun 2014 00:17:48 +0530
From: Vidya Sagar <vidyas@...dia.com>
To: <linux@....linux.org.uk>, <bhelgaas@...gle.com>,
<wangyijing@...wei.com>, <thierry.reding@...il.com>,
<jason@...edaemon.net>, <will.deacon@....com>,
<swarren@...dia.com>, <kthota@...dia.com>, <vidyas@...dia.com>
CC: <sagar.tv@...il.com>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH v2] ARM: fix debug prints relevant to PCI devices
As per PCIe spec, fast back-to-back transactions feature
is not applicable to PCIe devices. Hence, do not print
that fast back-to-back trasactions are disabled when
there is a PCIe device found on the bus
Signed-off-by: Vidya Sagar <vidyas@...dia.com>
---
v2:
* Modified has_pcie_dev type to bool and used pci_is_pcie() instead of pci_pcie_cap()
* replaced printk with pr_info
arch/arm/kernel/bios32.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
index 17a26c1..d48d9d3 100644
--- a/arch/arm/kernel/bios32.c
+++ b/arch/arm/kernel/bios32.c
@@ -290,6 +290,7 @@ void pcibios_fixup_bus(struct pci_bus *bus)
{
struct pci_dev *dev;
u16 features = PCI_COMMAND_SERR | PCI_COMMAND_PARITY | PCI_COMMAND_FAST_BACK;
+ bool has_pcie_dev = 0;
/*
* Walk the devices on this bus, working out what we can
@@ -298,6 +299,8 @@ void pcibios_fixup_bus(struct pci_bus *bus)
list_for_each_entry(dev, &bus->devices, bus_list) {
u16 status;
+ if (!has_pcie_dev)
+ has_pcie_dev = pci_is_pcie(dev);
pci_read_config_word(dev, PCI_STATUS, &status);
/*
@@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
/*
* Report what we did for this bus
+ * (only if the bus doesn't have even one PCIe device)
*/
- printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
- bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
+ if (!has_pcie_dev)
+ pr_info(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
+ bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
}
EXPORT_SYMBOL(pcibios_fixup_bus);
--
1.8.1.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists