linux-kernel - Re: [PATCH] media-device: Remove duplicated memset() in media_enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 07 Jun 2014 08:55:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Salva Peiró <speiro@....upv.es>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] media-device: Remove duplicated memset() in
 media_enum_entities()

On Sat, 2014-06-07 at 16:41 +0200, Salva Peiró wrote:
> After the zeroing the whole struct struct media_entity_desc u_ent,
> it is no longer necessary to memset(0) its u_ent.name field.

trivia:

> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
[]
> @@ -106,8 +106,6 @@ static long media_device_enum_entities(struct media_device *mdev,
>  	if (ent->name) {
>  		strncpy(u_ent.name, ent->name, sizeof(u_ent.name));
>  		u_ent.name[sizeof(u_ent.name) - 1] = '\0';

this could be strlcpy too.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/