linux-kernel - Re: [PATCH] media-device: Remove duplicated memset() in media_enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2014 13:51:20 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Salva Peiró <speiro@....upv.es>
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] media-device: Remove duplicated memset() in media_enum_entities()

Hi Salva,

Thank you for the patch.

On Saturday 07 June 2014 16:41:44 Salva Peiró wrote:
> After the zeroing the whole struct struct media_entity_desc u_ent,
> it is no longer necessary to memset(0) its u_ent.name field.
> 
> Signed-off-by: Salva Peiró <speiro@....upv.es>
> 
> To: Mauro Carvalho Chehab <m.chehab@...sung.com>
> CC: linux-media@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: stable@...nel.org

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

and applied to my tree.

> ---
>  drivers/media/media-device.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index 703560f..88c1606 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -106,8 +106,6 @@ static long media_device_enum_entities(struct
> media_device *mdev, if (ent->name) {
>  		strncpy(u_ent.name, ent->name, sizeof(u_ent.name));
>  		u_ent.name[sizeof(u_ent.name) - 1] = '\0';
> -	} else {
> -		memset(u_ent.name, 0, sizeof(u_ent.name));
>  	}
>  	u_ent.type = ent->type;
>  	u_ent.revision = ent->revision;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/