linux-kernel - Re: FW: Fwd: [RFC PATCH] mmc: mmci: Add qcom dml support to the driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CABu_nUQTu1_+sQ_Wkm1R=mOKtCP7GMcie7RJefGL=O6nOYyZrA@mail.gmail.com>
Date:	Thu, 17 Jul 2014 17:20:10 +0530
From:	Prakash Burla <burlaprakash.linuxkernel@...il.com>
To:	srinivas.kandagatla@...aro.org
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	chris@...ntf.net, ulf.hansson@...aro.org
Subject: Re: FW: Fwd: [RFC PATCH] mmc: mmci: Add qcom dml support to the driver.

tested-by: Prakash Burla <prakash.burla@...rtplayin.com>
This driver is tested on IFC6410.

>
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Date: Fri, Jul 11, 2014 at 5:18 PM
> Subject: [RFC PATCH] mmc: mmci: Add qcom dml support to the driver.
> To: linux-mmc@...r.kernel.org
> Cc: Linus Walleij <linus.walleij@...aro.org>, Chris Ball
> <chris@...ntf.net>, Ulf Hansson <ulf.hansson@...aro.org>, Russell King
> <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, Srinivas
> Kandagatla <srinivas.kandagatla@...aro.org>
>
>
> On Qualcomm APQ8064 SOCs, SD card controller has an additional glue
> called DML (Data Mover Local/Lite) to assist dma transfers.
> This hardware needs to be setup before any dma transfer is requested.
> DML itself is not a DMA engine, its just a gule between the SD card
> controller and dma controller.
>
> Most of this code has been ported from qualcomm's 3.4 kernel.
>
> This patch adds the code necessary to intialize the hardware and setup
> before doing any dma transfers.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>
> Hi All,
>
> DMA support for Qualcomm SD card controller is missing in my last patchset, the
> reason to post this patch separately is because of the unusual glue logic
> between card controller and the dma-controller. This glue logic is called DML
> (Data mover local/lite).
>
> DML assists dma transfers between sd card controller and dma-controller. As this
> DML gule is part of SD controller IP and needs configuring for every transfer,
> So I thought of keeping it close to driver in drivers/mmc/ directory is more
> usefull, than trying to find a infrastructure to fit it. DML itself is not a DMA
> controller but an logic present on SD card controller and it resides in SD card
> controller IP.
>
> I would like to get your opnion on overall correctness of the approch.
>
> Thanks in advance.
> srini
>
>
>  drivers/mmc/host/Kconfig    |  11 +++
>  drivers/mmc/host/Makefile   |   1 +
>  drivers/mmc/host/mmci.c     |  19 ++++-
>  drivers/mmc/host/qcom_dml.c | 171 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/mmc/host/qcom_dml.h |  17 +++++
>  5 files changed, 218 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/mmc/host/qcom_dml.c
>  create mode 100644 drivers/mmc/host/qcom_dml.h
>
.
[SNIP]
.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/