Message-ID: <5D833673AB94D9489A7F7F73E9E611C814AD9363@chn-hclt-mbs08.HCLT.CORP.HCL.IN>
Date:	Sun, 8 Jun 2014 19:15:08 +0000
From:	"Sathish Kumar Balasubramaniam -ERS, HCL Tech" 
	<b-sathishkumar@....com>
To:	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH 3.14.6 1/1] pinctrl/sh-pfc: fix pfc-r8a7790 pin mux data for
 IPSR5 bug

From: Sathish Kumar Balasubramaniam <b-sathishkumar@....com>

This patch fixes a bug in the list of peripheral functions for the IPSR5 pin mux configuration of the PFC (Pin Function Controller) of the Renesas R-Car H2 SoC (R8A7790). There should be exactly 8 values listed for the IP5_23_21 peripheral function which is using 3 bits. But there are 9 values present in the list.

This bug unexpectedly increases the internal position variable by 1 which is used by the PFC framework to identify the peripheral function. Due to this bug, peripheral function configuration from IP5_20_18 to IP5_2_0 may not work properly.

This issue can be easily reproduced by setting the FN_I2C1_SDA ( IP5_9_6 [4] ) which has the function value of 9 but the actual function value is set as 10 due to this bug.

-------------------------------------------------------------------------------
--- linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c.original    2014-06-08 22:03:44.681669692 +0530
+++ linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c    2014-06-08 22:02:10.361673511 +0530
@@ -4624,7 +4624,7 @@ static const struct pinmux_cfg_reg pinmu
         /* IP5_23_21 [3] */
         FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4,
         FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B,
-        FN_IERX_C, 0,
+        FN_IERX_C,
         /* IP5_20_18 [3] */
         FN_WE0_N, FN_IECLK, FN_CAN_CLK,
         FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0,


Signed-off-by: Sathish Kumar Balasubramaniam <b-sathishkumar@....com>



::DISCLAIMER::
----------------------------------------------------------------------------------------------------------------------------------------------------

The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only.
E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted,
lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents
(with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates.
Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the
views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification,
distribution and / or publication of this message without the prior written consent of authorized representative of
HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately.
Before opening any email and/or attachments, please check them for viruses and other defects.

----------------------------------------------------------------------------------------------------------------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists