linux-kernel - Re: [PATCH 3.14.6 1/1] pinctrl/sh-pfc: fix pfc-r8a7790 pin mux data for IPSR5 bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jun 2014 14:08:09 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	"Sathish Kumar Balasubramaniam -ERS, HCL Tech" 
	<b-sathishkumar@....com>
Cc:	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3.14.6 1/1] pinctrl/sh-pfc: fix pfc-r8a7790 pin mux data for IPSR5 bug

Hi Sathish,

Thank you for the patch. This has already been fixed in v3.15-rc4 by commit 
34ce57e9df7d14b52c7613bb2c190e411ca99186 ("sh-pfc: r8a7790: Fix definition of 
IPSR5").

On Sunday 08 June 2014 19:15:08 Sathish Kumar Balasubramaniam -ERS, HCL Tech 
wrote:
> From: Sathish Kumar Balasubramaniam <b-sathishkumar@....com>
> 
> This patch fixes a bug in the list of peripheral functions for the IPSR5 pin
> mux configuration of the PFC (Pin Function Controller) of the Renesas R-Car
> H2 SoC (R8A7790). There should be exactly 8 values listed for the IP5_23_21
> peripheral function which is using 3 bits. But there are 9 values present
> in the list.
> 
> This bug unexpectedly increases the internal position variable by 1 which is
> used by the PFC framework to identify the peripheral function. Due to this
> bug, peripheral function configuration from IP5_20_18 to IP5_2_0 may not
> work properly.
> 
> This issue can be easily reproduced by setting the FN_I2C1_SDA ( IP5_9_6 [4]
> ) which has the function value of 9 but the actual function value is set as
> 10 due to this bug.
> 
> ----------------------------------------------------------------------------
> --- --- linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c.original   
> 2014-06-08 22:03:44.681669692 +0530 +++
> linux-3.14.6/drivers/pinctrl/sh-pfc/pfc-r8a7790.c    2014-06-08
> 22:02:10.361673511 +0530 @@ -4624,7 +4624,7 @@ static const struct
> pinmux_cfg_reg pinmu
>          /* IP5_23_21 [3] */
>          FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4,
>          FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B,
> -        FN_IERX_C, 0,
> +        FN_IERX_C,
>          /* IP5_20_18 [3] */
>          FN_WE0_N, FN_IECLK, FN_CAN_CLK,
>          FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0,
> 
> 
> Signed-off-by: Sathish Kumar Balasubramaniam <b-sathishkumar@....com>

The SoB line should be before the patch content, not after. Beside, it seems 
that tabs have been converted to spaces. Please use git format-patch to 
generate patch files, and git send-email to send them.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/