linux-kernel - [PATCH v3 0/3] Add Qualcomm crypto driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1402315720-5042-1-git-send-email-svarbanov@mm-sol.com>
Date:	Mon,  9 Jun 2014 15:08:37 +0300
From:	Stanimir Varbanov <svarbanov@...sol.com>
To:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Grant Likely <grant.likely@...aro.org>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, Stanimir Varbanov <svarbanov@...sol.com>
Subject: [PATCH v3 0/3] Add Qualcomm crypto driver

Here is the third version of the crypto driver.

Changes since v2:

- reworked crypto_enqueue/dequeue_request mechanism. The queue
  length has been changed to one to reflect the hardware
  capabilities
- the workqueue has been deleted and replaced by new queue function
- few not functional changes like making some variables const
- fixed one issue in SG helper related to SG table manipulation
- added fallback for algorithms/modes unsupported by the hardware
- patches 1 to 6 are squashed in one i.e 1/3
- patches 7 and 8 are squashed in one i.e 2/3

regards,
Stan

---------------------------------------------------------------------
Here is the second version of the patch set. This time tagged
as an RFC to avoid confusions. The driver is splitted by files
and is buildable at the last patch. When the review has finished
1/9 to 7/9 could be squashed in one patch.

Any comments appreciated!

Changes since v1:

core
 - added MODULE_DEVICE_TABLE
 - reorganise includes
 - kernel doc comments
 - fix probe error path, forgot to destroy workqueue
 - rework clocks and kill loops for enabling
 - restructure the interfaces between core part of the driver
   and crypto type algorithms. Now struct qce_algo_ops has
   .unregister_algs operation and it is implemented by every
   algorithm type (unregister_algs was common in v1).
   Also async_req_queue/done are now part of core structure
   qce_device

regs-v5
 - use GENMASK and include bitops.h

dma-sg helpers
 - do not check !IS_ERR on error path
 - various fixes as per review comments
 - reorganise includes
 - return error on qce_dma_terminate_all

ablkcipher
 - use queue and done callbacks from struct qce_device
 - reorganise includes
 - kernel doc notation

sha-hmac
 - use queue and done callbacks from struct qce_device
 - make byte_count __be32
 - kernel doc notation
 - make rctx flags member unsigned long
 - cleanup qce_ahash_update function
 - make const * input args of qce_import_common

common
 - rename bits/masks to use _SHIFT suffix
 - reorganise includes and add qce_get_version function
 - make rctx flags unsigned long
 - move blocksize boundary check on function begging and
   clear BYTECOUNT registers on first processing block

This driver is based on Codeaurora's driver found at [1]

[1] https://www.codeaurora.org/cgit/quic/la/kernel/msm-3.10/tree/drivers/crypto/msm?h=msm-3.10

Stanimir Varbanov (3):
  crypto: qce: Qualcomm crypto engine driver
  crypto: qce: Build Qualcomm crypto driver
  ARM: DT: qcom: Add Qualcomm crypto driver binding document

 .../devicetree/bindings/crypto/qcom-qce.txt        |   25 +
 drivers/crypto/Kconfig                             |   15 +
 drivers/crypto/Makefile                            |    1 +
 drivers/crypto/qce/Makefile                        |    6 +
 drivers/crypto/qce/ablkcipher.c                    |  431 ++++++++++++++
 drivers/crypto/qce/cipher.h                        |   68 +++
 drivers/crypto/qce/common.c                        |  435 +++++++++++++++
 drivers/crypto/qce/common.h                        |  102 ++++
 drivers/crypto/qce/core.c                          |  286 ++++++++++
 drivers/crypto/qce/core.h                          |   68 +++
 drivers/crypto/qce/dma.c                           |  186 ++++++
 drivers/crypto/qce/dma.h                           |   58 ++
 drivers/crypto/qce/regs-v5.h                       |  334 +++++++++++
 drivers/crypto/qce/sha.c                           |  588 ++++++++++++++++++++
 drivers/crypto/qce/sha.h                           |   81 +++
 15 files changed, 2684 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/crypto/qcom-qce.txt
 create mode 100644 drivers/crypto/qce/Makefile
 create mode 100644 drivers/crypto/qce/ablkcipher.c
 create mode 100644 drivers/crypto/qce/cipher.h
 create mode 100644 drivers/crypto/qce/common.c
 create mode 100644 drivers/crypto/qce/common.h
 create mode 100644 drivers/crypto/qce/core.c
 create mode 100644 drivers/crypto/qce/core.h
 create mode 100644 drivers/crypto/qce/dma.c
 create mode 100644 drivers/crypto/qce/dma.h
 create mode 100644 drivers/crypto/qce/regs-v5.h
 create mode 100644 drivers/crypto/qce/sha.c
 create mode 100644 drivers/crypto/qce/sha.h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/