linux-kernel - Re: [PATCH 1/2] sched: Rework migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140611112411.GA21191@linux.vnet.ibm.com>
Date:	Wed, 11 Jun 2014 16:54:11 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Kirill Tkhai <ktkhai@...allels.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, tkhai@...dex.ru
Subject: Re: [PATCH 1/2] sched: Rework migrate_tasks()

* Kirill Tkhai <ktkhai@...allels.com> [2014-06-11 13:52:10]:

> 
> Currently migrate_tasks() skips throttled tasks,
> because they are not pickable by pick_next_task().
> 

Before migrate_tasks() is called, we do call set_rq_offline(), in
migration_call().

Shouldnt this take care of unthrottling the tasks and making sure that
they can be picked by pick_next_task().

> These tasks stay on dead cpu even after they
> becomes unthrottled. They are not schedulable
> till user manually changes their affinity or till
> cpu becomes alive again.
> 

If we are still seeing tasks not being picked by pick_next_task(), then
can it probably mean that rq->rd was NULL?

-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/