linux-kernel - Re: [PATCH] x86/tlb_uv: Fixing some memory allocation failure in x86 UV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1402455034.2719.3.camel@joe-AO725>
Date:	Tue, 10 Jun 2014 19:50:34 -0700
From:	Joe Perches <joe@...ches.com>
To:	Zhouyi Zhou <zhouzhouyi@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, mingo@...hat.com, x86@...nel.org,
	Peter Zijlstra <peterz@...radead.org>, cpw@....com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Zhouyi Zhou <yizhouzhou@....ac.cn>
Subject: Re: [PATCH] x86/tlb_uv: Fixing some memory allocation failure in
 x86 UV

On Wed, 2014-06-11 at 09:46 +0800, Zhouyi Zhou wrote:
> Thanks for reviewing, I will work on a new version

If you do, please remove the "out of memory" messages.

These messages are redundant to a generic OOM and
stack dump from the memory subsystem.

Less code is also makes it less likely to have an OOM.

btw: I added a new checkpatch test based on your patch.

https://lkml.org/lkml/2014/6/10/382


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/