linux-kernel - Re: [PATCH v2] uhci-platform: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1406111528170.890-100000@iolanthe.rowland.org>
Date:	Wed, 11 Jun 2014 15:32:27 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Himangi Saraogi <himangi774@...il.com>
cc:	Tony Prisk <linux@...sktech.co.nz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<julia.lawall@...6.fr>
Subject: Re: [PATCH v2] uhci-platform: use devm_ioremap resource

On Thu, 12 Jun 2014, Himangi Saraogi wrote:

> This patch replaces the memory allocation using request_mem_region and
> the ioremap by a single call to managed interface devm_ioremap_reource.
> The corresponding calls to release_mem_region and iounmap in the probe
> and release functions are now unnecessary and are removed. Also a label
> is done away with and linux/device.h is added to make sure the devm_*()
> outine declarations are unambiguously available.
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
> ---
> v2: pass correct arguments to devm_ioremap_resource
> Not compile tested due to incompatible architecture.

uhci-platform is compatible with all architectures.  But you have to 
add it to the .config file by hand.

>  drivers/usb/host/uhci-platform.c | 22 +++++-----------------
>  1 file changed, 5 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index 01833ab..b987f1d 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -8,6 +8,7 @@
>   */
>  
>  #include <linux/of.h>
> +#include <linux/device.h>
>  #include <linux/platform_device.h>
>  
>  static int uhci_platform_init(struct usb_hcd *hcd)
> @@ -88,33 +89,22 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
>  	hcd->rsrc_start = res->start;
>  	hcd->rsrc_len = resource_size(res);
>  
> -	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, hcd_name)) {
> -		pr_err("%s: request_mem_region failed\n", __func__);
> -		ret = -EBUSY;
> +	hcd->regs = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(hcd->regs)) {
> +		ret = PTR_ERR(hcd->regs);
>  		goto err_rmr;

Again, you didn't adjust the statement label.  The "rmr" in err_rmr 
stands for "request_mem_region", so it is clearly out of place in your 
patch.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/