linux-kernel - Re: [PATCH v2] uhci-platform: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1406112038420.2576@hadrien>
Date:	Wed, 11 Jun 2014 20:40:15 +0100 (BST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Alan Stern <stern@...land.harvard.edu>
cc:	Himangi Saraogi <himangi774@...il.com>,
	Tony Prisk <linux@...sktech.co.nz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] uhci-platform: use devm_ioremap resource

> > v2: pass correct arguments to devm_ioremap_resource
> > Not compile tested due to incompatible architecture.
>
> uhci-platform is compatible with all architectures.  But you have to
> add it to the .config file by hand.

What should one do exactly?  I added

CONFIG_USB_UHCI_PLATFORM=y

to the end of my .config file, but then running make just overwrites it:

> make drivers/usb/host/uhci-platform.o
scripts/kconfig/conf --silentoldconfig Kconfig
#
# configuration written to .config
#
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CALL    scripts/checksyscalls.sh
  CC      drivers/usb/host/uhci-platform.o
drivers/usb/host/uhci-platform.c:13:38: warning: ‘struct usb_hcd’ declared
inside parameter list [enabled by default]
 static int uhci_platform_init(struct usb_hcd *hcd)
                                      ^

thanks,
julia