linux-kernel - Re: [PATCH v2] uhci-platform: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1406111639420.890-100000@iolanthe.rowland.org>
Date:	Wed, 11 Jun 2014 16:45:03 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Julia Lawall <julia.lawall@...6.fr>
cc:	Himangi Saraogi <himangi774@...il.com>,
	Tony Prisk <linux@...sktech.co.nz>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] uhci-platform: use devm_ioremap resource

On Wed, 11 Jun 2014, Julia Lawall wrote:

> > > v2: pass correct arguments to devm_ioremap_resource
> > > Not compile tested due to incompatible architecture.
> >
> > uhci-platform is compatible with all architectures.  But you have to
> > add it to the .config file by hand.
> 
> What should one do exactly?  I added
> 
> CONFIG_USB_UHCI_PLATFORM=y
> 
> to the end of my .config file, but then running make just overwrites it:

By golly, you're right...  I didn't realize it would do that.

I guess you have to edit the drivers/usb/host/Kconfig file, changing

config USB_UHCI_PLATFORM
	bool
	default y if ARCH_VT8500

to

config USB_UHCI_PLATFORM
	bool
	default y

or something equivalent.

> 
> > make drivers/usb/host/uhci-platform.o
> scripts/kconfig/conf --silentoldconfig Kconfig
> #
> # configuration written to .config
> #
>   CHK     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/usb/host/uhci-platform.o
> drivers/usb/host/uhci-platform.c:13:38: warning: Ąstruct usb_hcdĸ declared
> inside parameter list [enabled by default]
>  static int uhci_platform_init(struct usb_hcd *hcd)

Do

	make drivers/usb/host/uhci-hcd.o

instead of

	make drivers/usb/host/uhci-platform.o

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/