linux-kernel - Re: [PATCH 2/2] staging: tidspbridge: Fix function pointer spacing in struct definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402716700.2756.3.camel@joe-AO725>
Date:	Fri, 13 Jun 2014 20:31:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Oczek <jeffoczek@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: tidspbridge: Fix function pointer spacing
 in struct definition

On Fri, 2014-06-13 at 22:48 -0400, Jeff Oczek wrote:
> Simple coding style changes
[]
> diff --git a/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h b/drivers/staging/tidspbridge/include/dspbridge/dblldefs.h
[]
> @@ -168,11 +168,11 @@ struct dbll_attrs {
[]
> -	 s32(*fread) (void *, size_t, size_t, void *);
> -	 s32(*fseek) (void *, long, int);
> -	 s32(*ftell) (void *);
> -	 s32(*fclose) (void *);
> -	void *(*fopen) (const char *, const char *);
> +	 s32 (*fread)(void *, size_t, size_t, void *);
> +	 s32 (*fseek)(void *, long, int);
> +	 s32 (*ftell)(void *);
> +	 s32 (*fclose)(void *);
> +	void *(*fopen)(const char *, const char *);
>  };

Better would be to describe the arguments with
variable names and align all the return values

	void *(*fopen

	s32 (*fread)(void *arg1, size_t val1, size_t val2, void *ptr1);
	s32 (*fseek)(void *ptr1, long arg2, int arg3);
	s32 (*ftell)(void * ptr);
	s32 (*fclose)(void *ptr);
	void *(*fopen)(const char *ptr1, const char *ptr2);

where arg, val, ptr are actually useful descriptors

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/