linux-kernel - Re: [Xen-devel] [PATCH v5 3/7] xen: Define EFI related stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539ECCCC.4030601@citrix.com>
Date:	Mon, 16 Jun 2014 11:54:04 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Daniel Kiper <daniel.kiper@...cle.com>,
	<linux-efi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<x86@...nel.org>, <xen-devel@...ts.xenproject.org>
CC:	<mjg59@...f.ucam.org>, <jeremy@...p.org>, <matt.fleming@...el.com>,
	<ian.campbell@...rix.com>, <andrew.cooper3@...rix.com>,
	<stefano.stabellini@...citrix.com>, <mingo@...hat.com>,
	<david.vrabel@...rix.com>, <jbeulich@...e.com>, <hpa@...or.com>,
	<boris.ostrovsky@...cle.com>, <tglx@...utronix.de>,
	<eshelton@...ox.com>
Subject: Re: [Xen-devel] [PATCH v5 3/7] xen: Define EFI related stuff

On 13/06/14 18:00, Daniel Kiper wrote:
> Define constants and structures which are needed to properly
> execute EFI related hypercall in Xen dom0.
> 
> This patch is based on Jan Beulich and Tang Liang work.
> 
> v5 - suggestions/fixes:

This version information should be after a '---' marker.

> +	struct {
> +		GUEST_HANDLE(void) name;  /* UCS-2/UTF-16 string */
> +		xen_ulong_t size;
> +		GUEST_HANDLE(void) data;
> +		struct xenpf_efi_guid {
> +			uint32_t data1;
> +			uint16_t data2;
> +			uint16_t data3;
> +			uint8_t data4[8];
> +			} vendor_guid;

Indentation looks all messed up here and in many other places.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/