linux-kernel - Re: [PATCH 1/6] arc,perf: Use common PMU interrupt disabled code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2014 13:16:12 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Vince Weaver <vincent.weaver@...ne.edu>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 1/6] arc,perf: Use common PMU interrupt disabled code

On Sunday 15 June 2014 11:25 AM, Vince Weaver wrote:
> Transition to using the new generic PERF_PMU_CAP_NO_INTERRUPT method for
> failing a sampling event when no PMU interrupt is available.
>
> Signed-off-by: Vince Weaver <vincent.weaver@...ne.edu>

Acked-by: Vineet Gupta <vgupta@...opsys.com>

Thx,
-Vineet

>
> diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
> index 63177e4..b9a5685 100644
> --- a/arch/arc/kernel/perf_event.c
> +++ b/arch/arc/kernel/perf_event.c
> @@ -99,10 +99,6 @@ static int arc_pmu_event_init(struct perf_event *event)
>  	struct hw_perf_event *hwc = &event->hw;
>  	int ret;
>  
> -	/* ARC 700 PMU does not support sampling events */
> -	if (is_sampling_event(event))
> -		return -ENOENT;
> -
>  	switch (event->attr.type) {
>  	case PERF_TYPE_HARDWARE:
>  		if (event->attr.config >= PERF_COUNT_HW_MAX)
> @@ -298,6 +294,9 @@ static int arc_pmu_device_probe(struct platform_device *pdev)
>  		.read		= arc_pmu_read,
>  	};
>  
> +	/* ARC 700 PMU does not support sampling events */
> +	arc_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;
> +
>  	ret = perf_pmu_register(&arc_pmu->pmu, pdev->name, PERF_TYPE_RAW);
>  
>  	return ret;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/