linux-kernel - Re: [PATCH] fs/cifs: fix regression in cifs_create_mf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539EF5FD.5000307@samba.org>
Date:	Mon, 16 Jun 2014 15:49:49 +0200
From:	"Stefan (metze) Metzmacher" <metze@...ba.org>
To:	Björn Baumbach <bb@...net.de>,
	Steve French <sfrench@...ba.org>
CC:	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Steve French <smfrench@...il.com>,
	Pavel Shilovsky <piastryyy@...il.com>
Subject: Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
> 
> Signed-off-by: Björn Baumbach <bb@...net.de>
> Signed-off-by: Stefan Metzmacher <metze@...ba.org>
> Reviewed-by: Stefan Metzmacher <metze@...ba.org>
> Cc: <stable@...r.kernel.org> # v3.14+
> Cc: Pavel Shilovsky <piastry@...rsoft.ru>
> Cc: Steve French <sfrench@...ba.org>
> ---
>  fs/cifs/link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>  	oparms.cifs_sb = cifs_sb;
>  	oparms.desired_access = GENERIC_WRITE;
>  	oparms.create_options = create_options;
> -	oparms.disposition = FILE_OPEN;
> +	oparms.disposition = FILE_CREATE;
>  	oparms.path = path;
>  	oparms.fid = &fid;
>  	oparms.reconnect = false;
> 


Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)