linux-kernel - Re: [PATCH] fs/cifs: fix regression in cifs_create_mf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mt+r3ab_gxZAYhF=buL3s3rz=dx9yEUyFh20mM9Yg08Ag@mail.gmail.com>
Date:	Mon, 16 Jun 2014 17:07:56 -0500
From:	Steve French <smfrench@...il.com>
To:	"Stefan (metze) Metzmacher" <metze@...ba.org>
Cc:	Björn Baumbach <bb@...net.de>,
	Steve French <sfrench@...ba.org>,
	"linux-cifs@...r.kernel.org" <linux-cifs@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, stable@...r.kernel.org,
	Pavel Shilovsky <piastryyy@...il.com>
Subject: Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

Although I have merged this into cifs-2.6.git for-next, in my testing
I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
I would like to fix that too (and mfsymlinks may be at least as
important there)

On Mon, Jun 16, 2014 at 8:49 AM, Stefan (metze) Metzmacher
<metze@...ba.org> wrote:
> Hi Steve,
>
> any comments on this? How can we get this fixed upstream?
>
> Thanks!
> metze
>
> Am 10.06.2014 12:03, schrieb Björn Baumbach:
>> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
>> ("CIFS: Cleanup cifs open codepath")
>> changed disposition to FILE_OPEN.
>>
>> Signed-off-by: Björn Baumbach <bb@...net.de>
>> Signed-off-by: Stefan Metzmacher <metze@...ba.org>
>> Reviewed-by: Stefan Metzmacher <metze@...ba.org>
>> Cc: <stable@...r.kernel.org> # v3.14+
>> Cc: Pavel Shilovsky <piastry@...rsoft.ru>
>> Cc: Steve French <sfrench@...ba.org>
>> ---
>>  fs/cifs/link.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
>> index 264ece7..68559fd 100644
>> --- a/fs/cifs/link.c
>> +++ b/fs/cifs/link.c
>> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>>       oparms.cifs_sb = cifs_sb;
>>       oparms.desired_access = GENERIC_WRITE;
>>       oparms.create_options = create_options;
>> -     oparms.disposition = FILE_OPEN;
>> +     oparms.disposition = FILE_CREATE;
>>       oparms.path = path;
>>       oparms.fid = &fid;
>>       oparms.reconnect = false;
>>
>



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/