linux-kernel - Re: [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539F05BA.7070004@imgtec.com>
Date:	Mon, 16 Jun 2014 15:56:58 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Vince Weaver <vincent.weaver@...ne.edu>,
	<linux-kernel@...r.kernel.org>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH 3/6] metag,perf: Use common PMU interrupt disabled code

Hi Vince,

On 15/06/14 07:03, Vince Weaver wrote:
> 
> Transition to using the new generic PERF_PMU_CAP_NO_INTERRUPT method for
> failing a sampling event when no PMU interrupt is available.
> 
> Signed-off-by: Vince Weaver <vincent.weaver@...ne.edu>


> @@ -866,6 +856,15 @@ static int __init init_hw_perf_events(void)
>  	pr_info("enabled with %s PMU driver, %d counters available\n",
>  			metag_pmu->name, metag_pmu->max_events);
>  
> +	/*
> +	 * Early cores have "limited" counters - they have no overflow
> +	 * interrupts - and so are unable to do sampling without extra work
> +	 * and timer assistance.
> +	 */
> +	if (metag_pmu->max_period == 0) {
> +		metag_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;
> +	}

The braces could be dropped.

Otherwise looks good to me,

Acked-by: James Hogan <james.hogan@...tec.com>

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/