linux-kernel - Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B0C4F83C-ACD6-49D0-B841-DBE1CBE3F5FC@intel.com>
Date:	Mon, 16 Jun 2014 04:55:08 +0000
From:	"Drokin, Oleg" <oleg.drokin@...el.com>
To:	Anil Belur <askb23@...il.com>
CC:	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<hpdd-discuss@...ts.01.org>" <hpdd-discuss@...ts.01.org>
Subject: Re: [PATCH v3 1/7] staging: lustre: lclient: glimpse.c fixing
 coding style issues

Hello!

On Jun 16, 2014, at 12:28 AM, Anil Belur wrote:

> From: Anil Belur <askb23@...il.com>
> 
> Fixed "ERROR: need consistent spacing around '+' (ctx:WxV)"
> 
> Signed-off-by: Anil Belur <askb23@...il.com>
> ---
> drivers/staging/lustre/lustre/lclient/glimpse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lclient/glimpse.c b/drivers/staging/lustre/lustre/lclient/glimpse.c
> index 7bbca4b..60a6e6e 100644
> --- a/drivers/staging/lustre/lustre/lclient/glimpse.c
> +++ b/drivers/staging/lustre/lustre/lclient/glimpse.c
> @@ -177,7 +177,7 @@ static int cl_io_get(struct inode *inode, struct lu_env **envout,
> 			io->ci_obj = clob;
> 			*envout = env;
> 			*ioout  = io;
> -			result = +1;
> +			result = + 1;

This looks wrong.
Here +1 is apparently meant as +1 (compare to -1) to underscore it's positive nature.
If you wanted to drop the +, that'd be fine, I guess, but in your version it looks outright wrong to me (I tested and it compiles, though).

Bye,
    Oleg--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/