linux-kernel - Re: [PATCH] ARM: zImage: ensure header in LE format for BE8 kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1406171200220.16842@knanqh.ubzr>
Date:	Tue, 17 Jun 2014 12:07:38 -0400 (EDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
cc:	Taras Kondratiuk <taras.kondratiuk@...aro.org>,
	Victor Kamensky <victor.kamensky@...aro.org>,
	linaro-networking@...aro.org,
	Ben Dooks <ben.dooks@...ethink.co.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: zImage: ensure header in LE format for BE8
 kernels

On Tue, 17 Jun 2014, Russell King - ARM Linux wrote:

> Given that we're now passing the linker script through GCC for C
> preprocessing, it seems to me that we don't need to do the sed trick
> anymore - we can pass TEXTADDR and ZBSSADDR into GCC via definitions
> instead, so I've committed this patch after this one.  No changes to
> the vmlinux.lds.* file, it's just a pure rename.  Ack?
> 
> From: Russell King <rmk+kernel@....linux.org.uk>
> Subject: [PATCH] ARM: Simplify generation of compressed vmlinux.lds file
> 
> As we are now using the C preprocessor, we do not need to use sed to
> edit constants in this file, and then pass the resulting file through
> the C preprocessor.  Instead, rely solely on the C preprocessor to
> rewrite TEXT_START and BSS_ADDR.
> 
> Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
> ---
>  arch/arm/boot/compressed/.gitignore     |  1 -
>  arch/arm/boot/compressed/Makefile       |  5 +-
>  arch/arm/boot/compressed/vmlinux.lds.S  | 90 +++++++++++++++++++++++++++++++++
>  arch/arm/boot/compressed/vmlinux.lds.in | 90 ---------------------------------

Would be easier to review with git diff -M.

> diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S
> new file mode 100644
> index 000000000000..60162231c7ea
[...]
> diff --git a/arch/arm/boot/compressed/vmlinux.lds.in b/arch/arm/boot/compressed/vmlinux.lds.in
> deleted file mode 100644
> index 60162231c7ea..000000000000

OK, the SHA1 is the same so both files are identical.

> --- a/arch/arm/boot/compressed/vmlinux.lds.in
> +++ /dev/null
> @@ -1,90 +0,0 @@
> -/*
> - *  linux/arch/arm/boot/compressed/vmlinux.lds.in

You might want to update this comment though.

Other than that...

Acked-by: Nicolas Pitre <nico@...aro.org>


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/