linux-kernel - Re: [PATCH 01/24] kobject: return actual error on kset_create_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1403021389.27991.11.camel@dabdike.int.hansenpartnership.com>
Date:	Tue, 17 Jun 2014 09:09:49 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Christoph Lameter <cl@...two.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Jeff Liu <jeff.liu@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, benh@...nel.crashing.org,
	paulus@...ba.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, stefanr@...6.in-berlin.de, joro@...tes.org,
	jejb@...isc-linux.org, deller@....de, bhelgaas@...gle.com,
	clm@...com, Josef Bacik <jbacik@...com>, swhiteho@...hat.com,
	bharrosh@...asas.com, bhalevy@...marydata.com, ccaulfie@...hat.com,
	teigland@...hat.com, Theodore Ts'o <tytso@....edu>,
	adilger.kernel@...ger.ca, jaegeuk@...nel.org,
	cm224.lee@...sung.com, Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>, casey@...aufler-ca.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/24] kobject: return actual error on
 kset_create_and_add

On Tue, 2014-06-17 at 11:00 -0500, Christoph Lameter wrote:
> On Tue, 17 Jun 2014, Greg KH wrote:
> 
> > Who really cares about that?  What can do you do with that additional
> > information that will help anything out?
> 
> The obvious reason for doing so is so that one can put the error code into
> a log message to get more detailed information on why the call failed.
> 
> In this particular case the slab allocator can give an error message that
> gives a hint why the sysfs support could not be enabled.

What useful information does this supply?  The current assumption on
NULL return is -ENOMEM ... what's the interesting case where this
assumption is wrong?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/